Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Move generic contracts and interfaces to examples #243

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

jawoznia
Copy link
Collaborator

As generic tests are big and rely on multiple configurations of interfaces and contracts I think it's a good idea to move them to examples.

It should allow us also to automate schema generation for those contracts.

@jawoznia jawoznia requested a review from hashedone October 23, 2023 17:39
@jawoznia jawoznia force-pushed the generic_examples branch 2 times, most recently from 195da40 to 0e3a9f7 Compare October 23, 2023 17:48
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #243 (89dc66c) into contract_supports_every_generic_message (dfa4f54) will decrease coverage by 2.64%.
The diff coverage is n/a.

@@                             Coverage Diff                             @@
##           contract_supports_every_generic_message     #243      +/-   ##
===========================================================================
- Coverage                                    88.54%   85.91%   -2.64%     
===========================================================================
  Files                                           25       24       -1     
  Lines                                         1685     1654      -31     
===========================================================================
- Hits                                          1492     1421      -71     
- Misses                                         193      233      +40     
Files Coverage Δ
sylvia-derive/src/multitest.rs 96.29% <ø> (-0.93%) ⬇️
sylvia/src/types.rs 80.00% <ø> (-20.00%) ⬇️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, with two small comments to address

examples/contracts/generic_contract/src/contract.rs Outdated Show resolved Hide resolved
examples/contracts/generic_contract/src/contract.rs Outdated Show resolved Hide resolved
@jawoznia jawoznia merged commit 4742385 into contract_supports_every_generic_message Oct 25, 2023
6 of 7 checks passed
@jawoznia jawoznia deleted the generic_examples branch October 25, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants